This repository was archived by the owner on Apr 11, 2023. It is now read-only.
Migration from irma_api_server to irmago server#1
Open
rolandgroen wants to merge 1 commit intoprivacybydesign:masterfrom
Open
Migration from irma_api_server to irmago server#1rolandgroen wants to merge 1 commit intoprivacybydesign:masterfrom
rolandgroen wants to merge 1 commit intoprivacybydesign:masterfrom
Conversation
…ma_api_server (https://github.com/privacybydesign/irma_api_server) to the new irmago server API (https://github.com/privacybydesign/irmago). The following changes have been applied: - The new irmajs library has been integrated, https://github.com/privacybydesign/irmajs in favor of https://github.com/credentials/irma_js. - The new API endpoints have been updated. - The session now created at the moment the button is clicked, instead of before, preventing timeout issues and refresh problems. The session endpoint is get_irma_session.php. - A missing dependency is added in composer.json. - Removal of the irma_web_server configuration setting - Fixing Undefined index: IRMA_INVALIDCREDENTIALS in /var/simplesamlphp/lib/SimpleSAML/Error/ErrorCodes.php
davidv1992
reviewed
Feb 11, 2020
davidv1992
left a comment
davidv1992
left a comment
There was a problem hiding this comment.
Thank you for your pull request, and our apologies for taking a while to respond to it. I have one question surrounding the proposed changes, but other than that they look fine to me.
| * On a successful login, this function should return the users attributes. On failure, | ||
| * it should throw an exception. If the error was due to invalid IRMA credentials, | ||
| * a SimpleSAML_Error_Error('IRMA_INVALIDCREDENTIALS') should be thrown. | ||
| * a SimpleSAML_Error_Error('RESPONSESTATUSNOSUCCESS') should be thrown. |
There was a problem hiding this comment.
What is the rationale here for wanting to switch to generic errors instead of the IRMA specific ones?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The migration of the simplesamlphp-module-authirma plugin from the irma_api_server (https://github.com/privacybydesign/irma_api_server) to the new irmago server API (https://github.com/privacybydesign/irmago).
The following changes have been applied: